Stg102/create file with data#48164
Open
browndav-msft wants to merge 6 commits intoAzure:feature/storage/stg102basefrom
Open
Stg102/create file with data#48164browndav-msft wants to merge 6 commits intoAzure:feature/storage/stg102basefrom
browndav-msft wants to merge 6 commits intoAzure:feature/storage/stg102basefrom
Conversation
- filePropertySemantics was not getting passed as an arg for the function in ShareDirectoryClient or ShareDirectoryAsyncClient - created recordings for the new tests
browndav-msft
requested review from
a team,
gunjansingh-msft,
ibrandes,
kyleknap and
seanmcc-msft
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Reintroduces the “create file with initial content” and “file property semantics” support (previously pulled) for Azure Storage File Share, while also bumping storage service versions to 2026-06-06 across related modules.
Changes:
- Add
filePropertySemanticsandBinaryDatapayload support back intoShareFileCreateOptionsand wire it through sync/async create calls. - Add
filePropertySemanticssupport back intoShareDirectoryCreateOptionsand wire it through sync/async create calls. - Update service version enums/defaults/tests to
2026-06-06and re-enable the previously pulled tests.
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/storage/azure-storage-queue/src/main/java/com/azure/storage/queue/QueueServiceVersion.java | Add 2026-06-06 service version and set it as latest. |
| sdk/storage/azure-storage-file-share/src/test/java/com/azure/storage/file/share/FileAsyncApiTests.java | Re-enable async tests for create-with-data and property semantics; bump required version. |
| sdk/storage/azure-storage-file-share/src/test/java/com/azure/storage/file/share/FileApiTests.java | Re-enable sync tests for create-with-data and property semantics; bump required version. |
| sdk/storage/azure-storage-file-share/src/test/java/com/azure/storage/file/share/DirectoryAsyncApiTests.java | Re-enable async directory tests for property semantics; bump required version. |
| sdk/storage/azure-storage-file-share/src/test/java/com/azure/storage/file/share/DirectoryApiTests.java | Re-enable sync directory tests for property semantics; bump required version. |
| sdk/storage/azure-storage-file-share/src/main/java/com/azure/storage/file/share/options/ShareFileCreateOptions.java | Restore filePropertySemantics + BinaryData fields and accessors. |
| sdk/storage/azure-storage-file-share/src/main/java/com/azure/storage/file/share/options/ShareDirectoryCreateOptions.java | Restore filePropertySemantics field and accessors. |
| sdk/storage/azure-storage-file-share/src/main/java/com/azure/storage/file/share/ShareServiceVersion.java | Add 2026-06-06 service version and set it as latest. |
| sdk/storage/azure-storage-file-share/src/main/java/com/azure/storage/file/share/ShareFileClient.java | Wire filePropertySemantics + initial data into sync create request. |
| sdk/storage/azure-storage-file-share/src/main/java/com/azure/storage/file/share/ShareFileAsyncClient.java | Wire filePropertySemantics + initial data into async create request and MD5 handling. |
| sdk/storage/azure-storage-file-share/src/main/java/com/azure/storage/file/share/ShareDirectoryClient.java | Wire filePropertySemantics into sync directory create request. |
| sdk/storage/azure-storage-file-share/src/main/java/com/azure/storage/file/share/ShareDirectoryAsyncClient.java | Wire filePropertySemantics into async directory create requests. |
| sdk/storage/azure-storage-file-share/assets.json | Update assets tag reference. |
| sdk/storage/azure-storage-file-datalake/src/main/java/com/azure/storage/file/datalake/implementation/util/TransformUtils.java | Refactor version conversion logic and add 2026-06-06 mapping. |
| sdk/storage/azure-storage-file-datalake/src/main/java/com/azure/storage/file/datalake/DataLakeServiceVersion.java | Add 2026-06-06 service version and set it as latest. |
| sdk/storage/azure-storage-common/src/main/java/com/azure/storage/common/implementation/UploadUtils.java | Restore sync computeMd5(ByteBuffer, ...) helper. |
| sdk/storage/azure-storage-common/src/main/java/com/azure/storage/common/implementation/Constants.java | Bump default SAS service version/target version string to 2026-06-06. |
| sdk/storage/azure-storage-common/ci.system.properties | Update CI system properties to use 2026-06-06. |
| sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/BlobServiceVersion.java | Add 2026-06-06 service version and set it as latest. |
...zure-storage-file-share/src/main/java/com/azure/storage/file/share/ShareFileAsyncClient.java
Outdated
Show resolved
Hide resolved
...ge-file-share/src/main/java/com/azure/storage/file/share/options/ShareFileCreateOptions.java
Outdated
Show resolved
Hide resolved
...ge-file-share/src/main/java/com/azure/storage/file/share/options/ShareFileCreateOptions.java
Outdated
Show resolved
Hide resolved
.../azure-storage-common/src/main/java/com/azure/storage/common/implementation/UploadUtils.java
Show resolved
Hide resolved
...age/azure-storage-file-share/src/main/java/com/azure/storage/file/share/ShareFileClient.java
Show resolved
Hide resolved
ibrandes
reviewed
Mar 5, 2026
Member
ibrandes
left a comment
ibrandes
left a comment
There was a problem hiding this comment.
this needs to be changed to point to the stg 102 feature branch rather than main. also, copilot left some comments that should be addressed imo.
ibrandes
reviewed
Mar 5, 2026
...age/azure-storage-file-share/src/main/java/com/azure/storage/file/share/ShareFileClient.java
Show resolved
Hide resolved
| @@ -1829,20 +1833,19 @@ public void directoryExistsHandlesParentNotFound() { | |||
| response.getHeaders().getValue(ERROR_CODE_HEADER_NAME)); | |||
| } | |||
|
|
|||
| /* PULLED FROM RELEASE | |||
| @RequiredServiceVersion(clazz = BlobServiceVersion.class, min = "2026-02-06") | |||
| @RequiredServiceVersion(clazz = BlobServiceVersion.class, min = "2026-06-06") | |||
Member
There was a problem hiding this comment.
create file with data still uses service version 2026-02-06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Readding the feature that was pulled from STG100